Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Input.Password ConfigProvider prefixCls not work #21953

Merged
merged 7 commits into from Mar 7, 2020
Merged

fix: Input.Password ConfigProvider prefixCls not work #21953

merged 7 commits into from Mar 7, 2020

Conversation

tdida
Copy link
Contributor

@tdida tdida commented Mar 6, 2020 •
edited by afc163

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

fix: Input.Password ConfigProvider prefixCls not work

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Mar 6, 2020

Could you add test case ?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 6, 2020 •
edited

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5f917d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited

Codecov Report

Merging #21953 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21953      +/-   ##
==========================================
+ Coverage   97.96%   97.96%   +<.01%     
==========================================
  Files         305      305              
  Lines        7017     7021       +4     
  Branches     1933     1934       +1     
==========================================
+ Hits         6874     6878       +4     
  Misses        143      143
Impacted Files Coverage 螖
components/input/Password.tsx 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c162bff...e5f917d. Read the comment docs.

@tdida
Copy link
Contributor Author

tdida commented Mar 6, 2020

鎴戝皾璇曚笅

@afc163 afc163 merged commit 23e4855 into ant-design:master Mar 7, 2020
@afc163 afc163 mentioned this pull request Mar 8, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Closed
This was referenced Mar 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tdida @afc163 @ant-design-bot